Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60052

Modal is not honoring the large setting, does not display wider

XMLWordPrintable

    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • Hide
      1. Use ngrok
      2. Add "http://lti.tools/test/tp.php" to Site administration > Plugins > Activity modules > External tool > Manage tools
      3. Add an instance of that tool to a course
      4. Press the "Select content" button
        1. Make sure the modal is large (see screenshots for reference)
      5. Go to Users > Enrolled users for the course.
        1. Make sure the model is small
      Show
      Use ngrok Add "http://lti.tools/test/tp.php" to Site administration > Plugins > Activity modules > External tool > Manage tools Add an instance of that tool to a course Press the "Select content" button Make sure the modal is large (see screenshots for reference) Go to Users > Enrolled users for the course. Make sure the model is small

      When opening a modal specifying the large option, the modal is not actually opening wider.

      This is an issue for example in LTI Content Selector as the UI to pick content is usually rich, and does not fit nicely in a tiny modal.

      This seems also as a regression due to style changes (class changing from large to modal-lg).

      Note that this was fixed in 3.4 (master) by MDL-59382 and this ticket is only a backport to 3.2 and 3.3 of the isolated commit fixing that issue alone.

        1. large_fixed.png
          large_fixed.png
          269 kB
        2. large_not_honored.png
          large_not_honored.png
          248 kB

            claudevervoort Claude Vervoort
            claudevervoort Claude Vervoort
            John Okely John Okely
            Andrew Lyons Andrew Lyons
            Andrew Lyons Andrew Lyons
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.