Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59545

Missing editing icons on activity pages

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.7
    • 3.3.1, 3.11.6, 4.0
    • Navigation, Themes
    • MOODLE_311_STABLE, MOODLE_33_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • wip_MDL-59545_master
    • Hide

      None.

      Show
      None.
    • Hide

      Requirements for both 3.11 & 4.0 testing

      1. Create a topics based course with a page module (default settings) and an assignment module (defaults but with rubric grading).
      2. Ensure that editing is on,

      Moodle 3.11:

      1. Boost theme selected
      2. Navigate to the page module within the course
      3. Confirm that the Administration section 'Page module administration' has icons against each menu item
      4. On the same page, confirm that the 'Cog' for the page has icons against each of the menu items.
      5. Navigate to the assignment module
      6. Confirm that the Administration section 'Assignment module administration' has icons against each menu item except 'Overrides' and 'Advanced grading'
      7. On the same page, confirm that the 'Cog' for the page has icons against each of the menu items, except 'Overrides' and 'Advanced grading'
      8. Switch to the Classic theme and repeat steps 2 to 7

      Moodle 4.0:

      1. Use the Classic theme
      2. Navigate to the page module within the test course
      3. Confirm that the Administration section 'Page module administration' has icons against each menu item
      4. Navigate to the assignment module
      5. Confirm that the Administration section 'Assignment module administration' has icons against each menu item except 'Overrides' and 'Advanced grading'
      Show
      Requirements for both 3.11 & 4.0 testing Create a topics based course with a page module (default settings) and an assignment module (defaults but with rubric grading). Ensure that editing is on, Moodle 3.11: Boost theme selected Navigate to the page module within the course Confirm that the Administration section 'Page module administration' has icons against each menu item On the same page, confirm that the 'Cog' for the page has icons against each of the menu items. Navigate to the assignment module Confirm that the Administration section 'Assignment module administration' has icons against each menu item except 'Overrides' and 'Advanced grading' On the same page, confirm that the 'Cog' for the page has icons against each of the menu items, except 'Overrides' and 'Advanced grading' Switch to the Classic theme and repeat steps 2 to 7 Moodle 4.0: Use the Classic theme Navigate to the page module within the test course Confirm that the Administration section 'Page module administration' has icons against each menu item Navigate to the assignment module Confirm that the Administration section 'Assignment module administration' has icons against each menu item except 'Overrides' and 'Advanced grading'

      I believe the fix for {}MDL-58808{} has introduced a regression. Without it, the Boost editing menu on activity pages had icons,

      but with the fix applied they are no longer displayed.

      Additional / update by Gareth:

      The actual problem is that there are no icons set in 'lib/navigationlib.php' (and what it calls) for module menu's and hence no icons on the menu's in the first place.

        1. edit_icons.png
          edit_icons.png
          23 kB
        2. edit_no_icons.png
          edit_no_icons.png
          19 kB
        3. M311_after.png
          M311_after.png
          14 kB
        4. M311_before.png
          M311_before.png
          29 kB
        5. M311_classic_after.png
          M311_classic_after.png
          19 kB
        6. M311_classic_before.png
          M311_classic_before.png
          17 kB
        7. M40_advanced_grading.png
          M40_advanced_grading.png
          19 kB
        8. M40_classic_after.png
          M40_classic_after.png
          16 kB
        9. M40_classic_before.png
          M40_classic_before.png
          14 kB
        10. MDL-59545_master_1.png
          MDL-59545_master_1.png
          81 kB
        11. MDL-59545_master_2.png
          MDL-59545_master_2.png
          104 kB
        12. MDL-59545_v311_1.png
          MDL-59545_v311_1.png
          66 kB
        13. MDL-59545_v311_2.png
          MDL-59545_v311_2.png
          117 kB
        14. MDL-59545_v311_3.png
          MDL-59545_v311_3.png
          77 kB
        15. MDL-59545_v311_4.png
          MDL-59545_v311_4.png
          94 kB

            gb2048 Gareth J Barnard
            tonybutler Tony Butler
            Glyn (Mathew) May Glyn (Mathew) May
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            2 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.