Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59329

Navigation and administration icons don't line up when FontAwesome enabled in a theme

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.3.1
    • Navigation, Themes
    • None
    • MOODLE_33_STABLE
    • Hide
      1. Edit the Clean theme config.php file and add '$THEME->iconsystem = \core\output\icon_system::FONTAWESOME;'.
      2. Purge all caches.
      3. On any page with the Navigation and Administration blocks expand the tree.
      4. Observe that the icons are in line.
      Show
      Edit the Clean theme config.php file and add '$THEME->iconsystem = \core\output\icon_system::FONTAWESOME;'. Purge all caches. On any page with the Navigation and Administration blocks expand the tree. Observe that the icons are in line.

      Thanks damyon for implementing MDL-58808, however the patch (https://github.com/moodle/moodle/commit/ae60722b14af0dbd664f5ef8ac1e4aa8ddbb72c3) is incomplete because it only applies the styles to the Boost theme.  The main purpose was to facilitate use of FontAwesome icons in the Navigation (and Administration) block(s) for any theme when '$THEME->iconsystem = \core\output\icon_system::FONTAWESOME;' was set in the theme config.php file.

      So there is a style issue with:

      .block_navigation .block_tree p.hasicon {
      text-indent: -21px;
      padding-left: 21px;
      }

      which when removed solves the problem.  Clearly this cannot be removed for when FontAwesome is not used and another possible selector introduced.

       

        1. MDL-59329.png
          50 kB
          Gareth J Barnard

            Unassigned Unassigned
            gb2048 Gareth J Barnard
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.