Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59230

tab_preferences AMD module does not load core/notification

XMLWordPrintable

    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • MOODLE_33_STABLE
    • MDL-59230-master
    • Hide
      Test 1
      1. Open blocks/myoverview/amd/src/tab_preferences.js
      2. Change methodname parameter on line 41 to something else:
        methodname: 'ccore_user_update_user_preferencesssss',
      3. Go to the dashboard and change a tab on course overview block.
      4. Make sure you see a pop up with the exception.
      Test 2

      Do a sanity check on the patch.

      Show
      Test 1 Open blocks/myoverview/amd/src/tab_preferences.js Change methodname parameter on line 41 to something else: methodname: 'ccore_user_update_user_preferencesssss', Go to the dashboard and change a tab on course overview block. Make sure you see a pop up with the exception. Test 2 Do a sanity check on the patch.

      During the testing of MDL-58907, I noticed the newly introduced AMD module tab_preferences.js is using Notification.exception here but it not loading core/notifications module here, that is prone to errors in the future.

            lameze Simey Lameze
            lameze Simey Lameze
            Mark Nelson Mark Nelson
            Jake Dallimore Jake Dallimore
            David Monllaó David Monllaó
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.