Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-59037

Fake blocks class changed from .block_fake to .block__fake in 3.2

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.2
    • HTML and CSS, Themes
    • None
    • MOODLE_32_STABLE

      The new renderer override and template used for Boost changes the classname of fake blocks from .fake_block to .fake__block (with a second underscore).

      It does this as it ignores the class set by the old code and builds the class in the template from

      block_{{{type}}}

      and "type" in this case is "_fake".

      This broke my theme CSS that targetted fake blocks, though I couldn't find any core CSS that relied on this class.

      I did find one bit of core JS that seems to expect that class though:

      lib/yui/src/blocks/js/manager.js
      103:                invalid: '.block-hider-hide, .block-hider-show, .moveto, .block_fake',

      It seems like it's intended to stop drag handles being put on fake blocks.

            Unassigned Unassigned
            bawjaws David Scotson
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.