Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58824

Decide how to handle redirections to external files in repositories

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.3
    • Repositories
    • MOODLE_33_STABLE

      This is a follow-up of MDL-58823

      Right now, repositories that supports links to external files are doing the redirections to those files using header('Location, this is not ideal, they should use the redirect() function

      The problem is that the redirect() function is not compatible with webservice/pluginfile.php because this php script is defined as an AJAX_SCRIPT (so on any redirection, the redirect function will trigger an exception)

      Ideally we should:

      • Use redirect in repositories
      • Remove the AJAX_SCRIPT from webservice/pluginfile.php but at the same time supporting JSON exceptions (that's the reason why is defined in that way)

            jleyva Juan Leyva
            jleyva Juan Leyva
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.