-
Task
-
Resolution: Fixed
-
Minor
-
None
-
3.3
-
MOODLE_33_STABLE
-
MDL-58442-master -
- Ensure all unit tests pass
- Read the comments in calendar/classes/local/container.php and ensure they make sense
- The core_ prefix is confusing and doesn't really add any value. It would be better to rename it simple 'container'.
- The container should be well documented as it's the place where all the building blocks are composed together to achieve the functionality we need.
- Since the container acts as a quasi-DI container, as well as deciding on concrete implementations to use, factories that are used only in the container are redundant.
- From the most recent IR: "Without dependency injection or similar systems, factories must serve a purpose to be useful; event_factory & event_abstract_factory together or separated make sense. I don't see though how action_event_factory serve any purpose, it is exactly the same to hardcode 'action_event_factory' in core_container than to hardcode 'new action_event', without a purpose nor an extension point they are 100% redundant. Getting rid of them would also kill action_event_factory_interface"