Loading...

XML

Word

Printable

Affected Branches:
MOODLE_33_STABLE
Fixed Branches:
MOODLE_37_STABLE
Epic Link:
Deprecate the bootstrapbase theme and remove from core
Pull from Repository:
git://github.com/sarjona/moodle.git
Pull Main Branch:
~~MDL-58428~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...sarjona:MDL-58428-master
Testing Instructions:

Hide

PHPUnit & Behat runs and passes.

A visual check of Moodle to ensure nothing on the frontend has changed.

This may be a scary looking PR but testing is primarily done via CI.

There is a specific fix for a regression of ~~MDL-49399~~ included if you want to specifically test that.

Current runs on Behat passing.
Clean: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/613/
Boost: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/612/

Show
PHPUnit & Behat runs and passes. A visual check of Moodle to ensure nothing on the frontend has changed. This may be a scary looking PR but testing is primarily done via CI. There is a specific fix for a regression of MDL-49399 included if you want to specifically test that. Current runs on Behat passing. Clean: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/613/ Boost: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/612/

All core templates should now belong to boost rather than bootstrapbase.
We need to:

move all existing core templates which are overridden by boost into the bootstrapbase theme
move all templates from boost to core

blocks

MDL-64940 Theme boost login logo

MDL-64505 Introduce the classic theme to core

Discovered while testing

MDL-55611 My course overview improvements

has a non-specific relationship to

MDL-64953 Tidy cibot issues after moving all templates from boost to core

Participants:: Adrian Greeve, Andrew Lyons, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Glyn (Mathew) May, Sara Arjona (@sarjona)