Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58391

"is_moodle_cookie_secure()" is buggy

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a bug
    • Icon: Minor Minor
    • None
    • 3.0.9, 3.2.2
    • Authentication
    • None
    • MOODLE_30_STABLE, MOODLE_32_STABLE

      "is_moodle_cookie_secure()" function returns wrong result. It cause wrong report at moodle security review page.

      https://github.com/moodle/moodle/blob/master/lib/sessionlib.php#L99

      orisinal

      if (!empty($CFG->loginhttps)) {
      		 
          return false;
      		 
      }

      correct

      if (empty($CFG->loginhttps)) {
      		 
          return false;
      		 
      }

            Unassigned Unassigned
            papillon326 Mitsuru Udagawa
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.