Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-58295

conversion update not called in some sitautions

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.3
    • 3.3
    • Files API
    • MOODLE_33_STABLE
    • MOODLE_33_STABLE
    • MDL-58295-master
    • Hide
      1. Configure unoconv correctly
      2. Upload a convertable document to an assignment in mod_assign
      3. View the document in the editPDF editor
        1. Confirm it works
      4. Upload a new document which is not of a supported type (.sh)
      5. View the document in the editPDF editor
        1. Confirm that no document is generated
      6. Configure Google Drive too (MDL-58280)
      7. Add the following to the very top of files/converter/unoconv/classes/converter.php::start_document_conversion: 

         $conversion->set('status', conversion::STATUS_FAILED);

      8. Upload another .doc file
      9. View the document in the editPDF editor
        1. Confirm that the document is generated
      Show
      Configure unoconv correctly Upload a convertable document to an assignment in mod_assign View the document in the editPDF editor Confirm it works Upload a new document which is not of a supported type (.sh) View the document in the editPDF editor Confirm that no document is generated Configure Google Drive too ( MDL-58280 ) Add the following to the very top of files/converter/unoconv/classes/converter.php::start_document_conversion : $conversion->set('status', conversion::STATUS_FAILED); Upload another .doc file View the document in the editPDF editor Confirm that the document is generated

      Noticed whilst PRing MDL-58280- there is:

      1. one instance where we need to call ->update() and do not;
      2. one instance where we probably should call ->update() and do not; and
      3. one instance where we do call ->update() and should not.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Ankit Agarwal Ankit Agarwal
            Jun Pataleta Jun Pataleta
            cameron1729 cameron1729
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.