Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57886

onlinetext submission should pass raw submissiontext to plagiarism get_links()

XMLWordPrintable

    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_34_STABLE
    • master_MDL-57886
    • Hide

      This is hard to test as no plagiarism plugins exist in core, and plagiarism plugins that support content submission all require subscriptions.

      Configure a plagiarism plugin to submit online submissions to the service (not all plagiarism plugins support this), submit some text and check to make sure the link to the plagiarism report is still available within the interface.

      I'm going to see if the different plagiarism plugin devs can test this change with their plugins and add support for this change here.

      Show
      This is hard to test as no plagiarism plugins exist in core, and plagiarism plugins that support content submission all require subscriptions. Configure a plagiarism plugin to submit online submissions to the service (not all plagiarism plugins support this), submit some text and check to make sure the link to the plagiarism report is still available within the interface. I'm going to see if the different plagiarism plugin devs can test this change with their plugins and add support for this change here.

      the plagiarism api receives raw "content" from the event that is triggered

         'content' => trim($data->onlinetext),
       
        $event = \assignsubmission_onlinetext\event\assessable_uploaded::create($params);
      

      but in get_links we are passing formatted stuff from the renderer - (including portfolio buttons)

      $text = $this->assignment->render_editor_content
      ...
      'content' => trim($text),
      

      this should really be consistent and we should pass the raw text to the get_links() function in view_summary probably by replacing trim($text) to trim($onlinetextsubmission->onlinetext)

            danmarsden Dan Marsden
            danmarsden Dan Marsden
            Dan Poltawski Dan Poltawski
            Mark Nelson Mark Nelson
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.