Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57134

Missing badgeslib.php include generates notices

XMLWordPrintable

    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-57134-master
    • Hide
      1. Log in as admin.
      2. Enable badges and course badges.
      3. Create a course badge, adding a criteria, enable it and award it to yourself.
      4. Visit Course > Badges (to trigger the event).
      5. Go to your profile page > Reports > All logs.
      6. You should not see any notices on the page (with debug level: developer)
      Show
      Log in as admin. Enable badges and course badges. Create a course badge, adding a criteria, enable it and award it to yourself. Visit Course > Badges (to trigger the event). Go to your profile page > Reports > All logs. You should not see any notices on the page (with debug level: developer)

      I just noticed some notices being displayed on Today's logs page.
      It is because MDL-55239 introduced additional events to badges, but some of those events (badge_listing_viewed for example) use BADGE constants like (BADGE_TYPE_SITE) but does not include badgeslib.

        1. notices.png
          notices.png
          124 kB

            lameze Simey Lameze
            lameze Simey Lameze
            Adrian Greeve Adrian Greeve
            Dan Poltawski Dan Poltawski
            Ankit Agarwal Ankit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.