Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-57069

Messaging loads past messages after latest messages

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 3.2
    • 3.2
    • Messages
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-57069_master
    • Hide

      It is important that you can reproduce this bug before confirming that this patch fixes it, just try it on stable.

      Test 1
      1. Ensure you have two users (A and B) that have a large list of messages (large enough so that the whole list of messages is not autoloaded the first time you open the conversation) between each other and the conversation is the most recent (ie. top of the list on the messaging page).
      2. Visit the messaging page and ensure the conversation is the first to load (so messages are loaded via PHP).
      3. Wait over 10 seconds.
      4. Check that there are no new messages loaded after the most recent one.
      5. Scroll up and confirm you can look at the history of the conversation.
      6. Log in as B in another browser and send A a message.
      7. Confirm the message appears on A's screen without needing to refresh the page (may need to wait).
      8. Look at the network tab for A and confirm only one message was received.
      Test 2
      1. Repeat testing instructions in MDL-56139 (no need to test the caching section though!).
      Show
      It is important that you can reproduce this bug before confirming that this patch fixes it, just try it on stable. Test 1 Ensure you have two users (A and B) that have a large list of messages (large enough so that the whole list of messages is not autoloaded the first time you open the conversation) between each other and the conversation is the most recent (ie. top of the list on the messaging page). Visit the messaging page and ensure the conversation is the first to load (so messages are loaded via PHP). Wait over 10 seconds. Check that there are no new messages loaded after the most recent one. Scroll up and confirm you can look at the history of the conversation. Log in as B in another browser and send A a message. Confirm the message appears on A's screen without needing to refresh the page (may need to wait). Look at the network tab for A and confirm only one message was received. Test 2 Repeat testing instructions in MDL-56139 (no need to test the caching section though!).

      Issue coming from MDL-56139, discovered while testing MDL-56938. See the attached screenshot.

      The first core_message_data_for_messagearea_messages is sent with timefrom = 0, I can't remember the internals, but it may just be that that 0 should be the latest message timecreated instead.

      Steps to reproduce:

      1. Use a couple of users with a big list of exchanged messages (big enough so that the whole list of messages is not autoloaded the first time you open the conversation with these 2 users, you can ensure that it is big enough if you go to the first loaded message and previous messages are loaded)
      2. Open again that conversation (so there are previous messages that haven't been loaded yet)
      3. Wait a few seconds
      4. You will see how the previous messages are loaded after the latest message between those 2 users

        1. previous-messages-appended.png
          200 kB
          David Monllaó

            markn Mark Nelson
            dmonllao David Monllaó
            Frédéric Massart Frédéric Massart
            David Monllaó David Monllaó
            Jun Pataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.