Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56858

boost: Checkbox label and description appear on the same line causing confusion

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2
    • 3.2
    • Themes
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-56858_master-alt-2
    • Hide
      Test 1
      1. Switch to the 'Boost' theme if you are not already using it.
      2. Add the following code located at https://gist.github.com/markn86/d5986f9aaad68286e9154f61a706c187 to test.php in your wwwroot.
      3. Visit <yoursite>/test.php.
      4. Ensure that when the label AND text is provided the label is on the left and the text is on the right of the input field.
      5. Ensure that when just the label is provided the label is on the right of the input field.
      6. Ensure that when just the text is provided the text is on the right of the input field.
      7. For the elements in the group ensure they all appear on the same row and the 'Text' is in <em> tags.
      8. Confirm the advanced symbol is shown on all elements.
      9. Confirm the required symbol is shown on only the radio buttons and group.
      Test 2
      1. Test on clean but this time just make sure it looks how it did on stables.
      Test 3
      1. Ensure Behat isn't having a sad.
      Show
      Test 1 Switch to the 'Boost' theme if you are not already using it. Add the following code located at https://gist.github.com/markn86/d5986f9aaad68286e9154f61a706c187 to test.php in your wwwroot. Visit <yoursite>/test.php. Ensure that when the label AND text is provided the label is on the left and the text is on the right of the input field. Ensure that when just the label is provided the label is on the right of the input field. Ensure that when just the text is provided the text is on the right of the input field. For the elements in the group ensure they all appear on the same row and the 'Text' is in <em> tags. Confirm the advanced symbol is shown on all elements. Confirm the required symbol is shown on only the radio buttons and group. Test 2 Test on clean but this time just make sure it looks how it did on stables. Test 3 Ensure Behat isn't having a sad.

      Eg.

      $mform->addElement('checkbox', 'the_name_of_checkbox', 'Label', 'Text');
      

      In Clean 'Label' appears in bold on the left of the checkbox, where as in Boost it appears in the same font and position as 'Text' on the right of the checkbox.

        1. activity_completion_with_alt_2_patch.png
          25 kB
          Mark Nelson
        2. activity_completion_with_alt_patch.png
          25 kB
          Mark Nelson
        3. activity_completion_with_original_patch.png
          27 kB
          Mark Nelson
        4. activity completion settings forum.png
          31 kB
          Helen Foster
        5. advanced.png
          88 kB
          Frédéric Massart
        6. boost.png
          37 kB
          Kevin Wiliarty
        7. clean.png
          39 kB
          Kevin Wiliarty
        8. screenshot-1.png
          42 kB
          David Mudrák (@mudrd8mz)

            markn Mark Nelson
            markn Mark Nelson
            cameron1729 cameron1729
            Andrew Lyons Andrew Lyons
            Frédéric Massart Frédéric Massart
            Votes:
            1 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.