-
Improvement
-
Resolution: Won't Do
-
Major
-
None
-
3.1.2, 3.2.3, 3.3.1
-
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE
-
WIP-
MDL-56437
The get_converted_document() function in lib/filestorage/file_storage.php is capable of returning false if the function that does the work - create_converted_document() - indicates a failure. The latter actually makes a useful check that unconv has generated a new file in the temporary area and returns false if none is found. Unoconv is far from 100% reliable, we see quite a few 'Office probably died' errors and no conversion is produced, so this is a real problem.
Unfortunately, when this is called in Assignment the return value is mostly ignored. If false is returned the calling code just drops through. This, presumably, is what results in spinning wheels followed by a blank page in the grading screen rather than a useful error message.
- has been marked as being related by
-
MDL-59911 Unoconv doesn't work after the scheduled task conversion_cleanup_task has run
-
- Closed
-
-
MDL-54554 Improve error handling for unoconv (Universal Office Converter)
-
- Closed
-
-
MDL-58971 touch() in unoconv temp file creation needs better protection
-
- Closed
-
- will help resolve
-
MDL-55859 Assignment pdf conversion doesn't clean up after failure
-
- Closed
-