Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-56436

Update mustache.php readme to indicate its no longer custom

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2
    • 3.1.2, 3.2
    • HTML and CSS

      lib/mustache/readme_moodle.txt says:

      Clone from https://github.com/moodle/custom-mustache.php
      Rebase onto latest tag from https://github.com/bobthecow/mustache.php

      Yet, on 3.1, if I do..

      wget https://github.com/bobthecow/mustache.php/archive/v2.10.0.tar.gz
      tar -xzvf v2.10.0.tar.gz
      rm -R lib/mustache/src/
      $  mv mustache.php-2.10.0/src/ lib/mustache/
      

      There are no differences. (Same applies to 3.2 and v2.11.1).

      So either:

      • We are missing some commits (and have a broken functionality for multiple releases)
      • The readme_moodle.txt is outdated and needs to be fixed

      The status of https://github.com/moodle/custom-mustache.php is really unclear. Which branch do you rebase and so on?

      This needs sorting out

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.