Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.0.7, 3.1.3
Affects Version/s: 3.0.5, 3.1.1, 3.2
Component/s: Course
Labels:
- ci
- triaged

Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Main Branch:
~~MDL-55804~~_master
Pull Main Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-55804_master~2...MDL-55804_master
Testing Instructions:
Hide

Use tool_uploadcourse to upload a csv with courses data

Upload mode: Create new courses or update existing ones

Update mode: Update with CSV data and defaults

Set the default start date to 2020

Create the course and check its start date, it should be the one you set in 2020

Try to find another date_selector or datetime_selector field in moodle which name is part of an array and if you do check that everything is working as it should. I've tried to find a form like this with git grep "date.[a-z_A-Z][[a-z_A-Z]" but I couldn't. If you do find one comment about it here please.
Show
Use tool_uploadcourse to upload a csv with courses data Upload mode: Create new courses or update existing ones Update mode: Update with CSV data and defaults Set the default start date to 2020 Create the course and check its start date, it should be the one you set in 2020 Try to find another date_selector or datetime_selector field in moodle which name is part of an array and if you do check that everything is working as it should. I've tried to find a form like this with git grep "date. [a-z_A-Z] [ [a-z_A-Z] " but I couldn't. If you do find one comment about it here please.

While working on ~~MDL-22078~~ I've noticed that start date and end date were not set as defaults.

There are two different issues:

moodleforms dateselector (datetimeselector as well) are not returning values through moodleforms::_prepareValue so 'defaults' field name prefix is not converted into a 1 array level
https://github.com/moodle/moodle/blob/master/admin/tool/uploadcourse/classes/course.php#L635 should be applied to the csv values, not to the default values

I think this has never been tested.

blocks

MDL-22078 Course End Date

Closed

Assignee:: David Monllaó

Reporter:: David Monllaó

Peer reviewer:: Simey Lameze

Integrator:: Eloy Lafuente (stronk7)

Tester:: Mark Nelson

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Mark Nelson, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 31/Aug/16 9:28 PM

Updated:: 29/Nov/16 12:51 AM

Resolved:: 30/Sep/16 7:21 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify