Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 4.1.7, 4.2.4, 4.3.1
Affects Version/s: 3.0.5, 3.1.1, 3.2
Component/s: Unit tests
Labels:
- CatalystIT
- ci
- developer_notes
- partner
- random_fail
- triaged

Affected Branches:
MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
Epic Link:
CI random failures
Pull from Repository:
https://github.com/sammarshallou/moodle.git
Pull 4.1 Branch:
~~MDL-55640~~-m401
Pull 4.1 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_401_STABLE...MDL-55640-m401
Pull 4.3 Branch:
~~MDL-55640~~-m403
Pull 4.3 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_403_STABLE...MDL-55640-m403
Pull Main Branch:
~~MDL-55640~~-main
Pull Main Diff URL:
https://github.com/sammarshallou/moodle/compare/main...MDL-55640-main
Testing Instructions:

Hide

No manual testing necessary, just confirm that PHPunit tests, specifically setupilib_test::test_localcachedir, still pass.

There is no way to test this has actually fixed the problem as it is a sporadic failure, the only thing to check is that it doesn't actually break the test any worse...

Show
No manual testing necessary, just confirm that PHPunit tests, specifically setupilib_test::test_localcachedir, still pass. There is no way to test this has actually fixed the problem as it is a sporadic failure, the only thing to check is that it doesn't actually break the test any worse...

There have been issues created about this before, but it seems that core_setuplib_testcase::test_localcachedir fails quite frequently on windows:

1) core_setuplib_testcase::test_localcachedir

Time is lower that allowed start value

Failed asserting that 1471547752 is equal to 1471547753 or is greater than 1471547753.

C:\projects\moodle\lib\phpunit\classes\advanced_testcase.php:403

C:\projects\moodle\lib\tests\setuplib_test.php:170

C:\projects\moodle\lib\phpunit\classes\advanced_testcase.php:80

Note this also fails in other OS, reportedly with dockered stuff @ CI.

has a non-specific relationship to

MDL-80443 core_setuplib_testcase::test_localcachedir fails regularly (Take 2)

MDL-45204 Random unit test failures related with file information

MDL-41779 Unit tests: Time-dependent tests fail randomly

MDL-42700 False-positive unit test failure

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Paul Holden, Rajesh Taneja, Sam Marshall, Sara Arjona (@sarjona), Simey Lameze, Tim Hunt

Estimated:

Remaining:

Logged:

1h 38m