-
Task
-
Resolution: Won't Do
-
Minor
-
None
-
3.2
-
MOODLE_32_STABLE
Our CSS guidelines say that selectors should not be overqualified
Apply this patch:
diff --git a/mod/assign/styles.css b/mod/assign/styles.css
|
index cdbadb2..d37cb93 100644
|
--- a/mod/assign/styles.css
|
+++ b/mod/assign/styles.css
|
@@ -1,5 +1,3 @@
|
-/* stylelint-disable max-line-length */
|
-/* FIXME: MDL-55370: remove this stylelint disable */
|
.path-mod-assign div.gradingnavigation div {
|
float: left;
|
|
Run grunt css
>> mod/assign/styles.css
|
>> 692:74 ⚠ Expected line length to be no more than 132 characters max-line-length
|
>> 888:86 ⚠ Expected line length to be no more than 132 characters max-line-length
|
>> 899:82 ⚠ Expected line length to be no more than 132 characters max-line-length
|
>> 936:77 ⚠ Expected line length to be no more than 132 characters max-line-length
|
>> 937:76 ⚠ Expected line length to be no more than 132 characters max-line-length
|
>> Linted 956 files without errors
|
Look at the CSS:
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.fitem_ftext .felement,
|
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.fitem_f .felement,
|
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.fitem_feditor .felement,
|
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.fitem_fgrading .felement,
|
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.fitem_ffilemanager .felement {
|
padding: 6px 10px 10px;
|
box-sizing: border-box;
|
}
|
.path-mod-assign #page-content [data-region="grade-panel"] .mform:not(.unresponsive) .fcontainer .fitem.popout .felement .gradingform_rubric {
|
overflow: visible;
|
}
|
And it becomes clear we've might be a little overqualified there
- will be (partly) resolved by
-
MDL-56318 theme_boost: Assignment Grading interface missing some styling
-
- Closed
-