Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-55050

grunt watch causes eslint of all files on any js change.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.2
    • 3.2
    • JavaScript
    • MOODLE_32_STABLE
    • MOODLE_32_STABLE
    • MDL-55050-master
    • Hide

      It's kind of difficult to test this, the most reliable way is probably to:

      1. To run grunt watch --verbose
      2. Edit a amd src file or yui src file
      3. Inspect the output of eslint task and ensure it only runs eslint on the file which was edited (compare with before patch to see the difference)

      Alternatively you could observe that the eslint part runs much quicker.

      Show
      It's kind of difficult to test this, the most reliable way is probably to: To run grunt watch --verbose Edit a amd src file or yui src file Inspect the output of eslint task and ensure it only runs eslint on the file which was edited (compare with before patch to see the difference) Alternatively you could observe that the eslint part runs much quicker.

      Every time we do a JS change, we eslint all the js files rather than just the modified ones. Doh

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Andrew Lyons Andrew Lyons
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.