Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53994

Feedback block broken on 3.1 upgrade

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.1
    • 3.1
    • Feedback
    • MOODLE_31_STABLE
    • MOODLE_31_STABLE
    • Hide

      Run the behat scenario:

      --name 'Site feedback deletion hides feedback block completely'

      with the patch applied it passes.

      Without the require_once() added by the patch, it fails.

      Let CI to run the complete phpunit/behat tests, all them should pass, this is not expected to introduce any regression.

      Show
      Run the behat scenario: --name 'Site feedback deletion hides feedback block completely' with the patch applied it passes. Without the require_once() added by the patch, it fails. Let CI to run the complete phpunit/behat tests, all them should pass, this is not expected to introduce any regression.

      From the chat:

      15:36:37 Mary Cooch: help!!
      15:36:49 Dan P: whats up?
      15:36:49 Mary Cooch: I just upgraded my 3.1 dev site and it is broken
      15:37:41 Mary Cooch: Fatal error: Call to undefined function feedback_get_feedbacks_from_sitecourse_map() in /var/www/vhosts/geographydiva.com/httpdocs/moodle/blocks/feedback/block_feedback.php on line 59

      Looks to me like like it was caused by this removal:
      https://github.com/moodle/moodle/commit/aeeeb78847ed0121a835a476f219c4cf4be99f92#diff-49d6c8324b4d4197171d657a07cd6eb8L25

            stronk7 Eloy Lafuente (stronk7)
            poltawski Dan Poltawski
            Mark Nelson Mark Nelson
            David Monllaó David Monllaó
            John Okely John Okely
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.