Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-53180

Recent move/upgrade of html2text was not performed in thirdpartylibs.xml

XMLWordPrintable

    • MOODLE_30_STABLE
    • MOODLE_30_STABLE
    • Easy
    • Hide

      Not much can be done but verifying that the new location is correct, relative to the thirdpartylibs.xml location.

      Note this is only 30_STABLE, master was fixed some days ago @ MDL-53393 and previous branches are correct.

      Optionally, if can run CiBoT reports in any way (mdk, integrator...)... you can:

      1) With the patch NOT applied (or reverted).
      2) Edit lib/html2text/Html2Text.php and modify some line (renaming a variable to have underscores, a method name to have upper case characters... anything that usually the codechecker will detect.
      3) Run the CiBoT job against such modifications.
      4) TEST: the codechecker reports the coding style violations.
      5) TEST: cibot does not detect that a change has happened, so the thirdparty section does not show any problem.

      Note that 4 and 5 are what we are trying to fix here by properly setting the location of the library.

      6) With the patch applied
      7) Run CiBoT job again for the same modifications you did in 2)
      8) TEST: the codechecker DOES NOT report the coding style violations anymore (now it's ignored because it's considered 3rd part library properly).
      9) TEST: cibot detects a change in a library has happened and the thirdparty section informs you that those changes must be documented.

      Note that 8 and 9 are the correct expectations (code style ignored and changes detected for documentation purposes) when changes in a library are detected.

      That's all.

      Show
      Not much can be done but verifying that the new location is correct, relative to the thirdpartylibs.xml location. Note this is only 30_STABLE, master was fixed some days ago @ MDL-53393 and previous branches are correct. Optionally, if can run CiBoT reports in any way (mdk, integrator...)... you can: 1) With the patch NOT applied (or reverted). 2) Edit lib/html2text/Html2Text.php and modify some line (renaming a variable to have underscores, a method name to have upper case characters... anything that usually the codechecker will detect. 3) Run the CiBoT job against such modifications. 4) TEST: the codechecker reports the coding style violations. 5) TEST: cibot does not detect that a change has happened, so the thirdparty section does not show any problem. Note that 4 and 5 are what we are trying to fix here by properly setting the location of the library. 6) With the patch applied 7) Run CiBoT job again for the same modifications you did in 2) 8) TEST: the codechecker DOES NOT report the coding style violations anymore (now it's ignored because it's considered 3rd part library properly). 9) TEST: cibot detects a change in a library has happened and the thirdparty section informs you that those changes must be documented. Note that 8 and 9 are the correct expectations (code style ignored and changes detected for documentation purposes) when changes in a library are detected. That's all.

      With MDL-51524 the html2text library was updated to new version and moved to lib/html2text directory. But that changed was not served with the corresponding change in thirdpartylibs.xml

      As results of that lib/html2text is not identified anymore as a 3rd part library and:

      1) code checker is processing its code (that is not Moodle code).
      2) 3rd part changes checker is not detecting changes in 30 and up.

      See this report as an example of both problems.

      So this is about to update thirdpartylibs.xml to point to correct new location of the library. 30 and up. Should be easy.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Simey Lameze Simey Lameze
            Dan Poltawski Dan Poltawski
            Marina Glancy Marina Glancy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.