Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 3.0.1
Affects Version/s: 3.0
Component/s: Questions
Labels:
- ci
- triaged

Affected Branches:
MOODLE_30_STABLE
Fixed Branches:
MOODLE_30_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Main Branch:
~~MDL-52553~~_master
Pull Main Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-52553_master~...MDL-52553_master
Testing Instructions:
Hide

Based on ~~MDL-52203~~ testing instructions.

In Moodle 2.9 create several cloze questions, see examples in https://docs.moodle.org/29/en/Embedded_Answers_%28Cloze%29_question_type, ensure they include multichoice questions

Manually edit one of them in the database, in table question_multianswer replace sequence '1,2,3,4' with ',,,'

Perform upgrade to 3.0 branch

Make sure it succeeded
Show
Based on MDL-52203 testing instructions. In Moodle 2.9 create several cloze questions, see examples in https://docs.moodle.org/29/en/Embedded_Answers_%28Cloze%29_question_type , ensure they include multichoice questions Manually edit one of them in the database, in table question_multianswer replace sequence '1,2,3,4' with ',,,' Perform upgrade to 3.0 branch Make sure it succeeded

I've upgraded a monster database to 3.0 and I see some php notices in the CLI output:

Notice: Use of undefined constant ANSWER_REGEX - assumed 'ANSWER_REGEX' in /home/davidm/Desktop/moodlecode/int/MOODLE_30_STABLE/question/type/multianswer/db/upgrade.php on line 85

Notice: Use of undefined constant ANSWER_REGEX_ANSWER_TYPE_MULTICHOICE - assumed 'ANSWER_REGEX_ANSWER_TYPE_MULTICHOICE' in /home/davidm/Desktop/moodlecode/int/MOODLE_30_STABLE/question/type/multianswer/db/upgrade.php on line 86

This is probably a regression caused by ~~MDL-52162~~, as I removed question/type/multianswer/questiontype.php include there.

Would be good to fix this before releasing 3.0.1.

is a regression caused by

MDL-52162 Upgrade to 3.0 through the browser fails: class question_graded_automatically not found

Closed

Testing discovered

MDLSITE-4366 Upgrade step checker failing on MDL-52553

Closed

Assignee:: David Monllaó

Reporter:: David Monllaó

Peer reviewer:: Frédéric Massart

Integrator:: Dan Poltawski

Tester:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Frédéric Massart, Rajesh Taneja, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 18/Dec/15 7:27 PM

Updated:: 20/Dec/15 2:07 AM

Resolved:: 19/Dec/15 7:59 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify