-
Bug
-
Resolution: Fixed
-
Minor
-
2.8.6, 2.9.1, 3.0
-
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
-
MOODLE_28_STABLE, MOODLE_29_STABLE
-
MDL-50921-master -
Whenever messages are created with the useridfrom field set to -10 or -20, the message popups never show.
Steps to recreate the problem:
- Login as an instructor, and navigate to one of your courses.
- Create a forum that students can post to.
- Setup an event monitoring rule for the forum event "Discussion created".
- Set messaging settings in the "Event monitor" section to allow "Popup notification"
- Login as a student in the course.
- Create a discussion in the forum
- Run the cron.
- Login as the instructor. Popup notifications should not show.
I fixed the problem on my test instance by editing the "message_popup_window" function in "lib/moodlelib.php". I deleted the following line from the query:
JOIN mdl_user u ON m.useridfrom=u.id
This JOIN was causing no messages to be returned because the useridfrom field for those types of messages contained a "-10" (i.e. noreply user). After looking at the history of changes to that query, I don't think the JOIN is needed any longer.
- has been marked as being related by
-
MDL-46620 Blocked user auto message marking looses message info
-
- Closed
-