Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-50830

Incorrect permission checks in the singleview report

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Duplicate
    • Icon: Minor Minor
    • None
    • 2.9
    • Gradebook
    • None
    • MOODLE_29_STABLE

      We found out, that a role corrector cannot edit grades in singleview, because he hasn't the capability moodle:grade/manage (grade/report/singleview/lib.php)
      However he has the capabilities moodle/grade:edit and moodle/singleview:view.

      We think, that the requested moodle:grade/manage should be replaced by the moodle/grade:edit capability in the function

      public function process_data($data) {
      if (has_capability('moodle/grade:manage', $this->context))
      { return $this->screen->process($data); }
      } 
      

      in line 54.

      To edit grades it is not necessary to be able to manage other settings related to grading.

            Unassigned Unassigned
            kosswa Kathrin Osswald
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.