Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49939

course/user.php review

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.9
    • Course
    • MOODLE_29_STABLE

      While working on the MDL-49854 we've noticed that course/user.php code is confusing and is prone to errors.

      Even if you define the mode parameter to some wrong string it does take you to user grades report. The user.php page does many checks and redirect to different places relying on the mode param but as commented in https://tracker.moodle.org/browse/MDL-49854?focusedCommentId=351207&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-351207 there are some weird behaviours.

      Would be great to do a proper review looking where this script is called from and do a proper cleanup.

            Unassigned Unassigned
            lameze Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.