Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49244

core_course_get_categories doesn't clean the criteria parameters

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.0.5, 3.1.1
    • 2.7.5, 2.8.3, 2.9.6, 3.0.4, 3.1, 3.2
    • Web Services
    • MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • MOODLE_30_STABLE, MOODLE_31_STABLE
    • MDL-49244-master
    • Hide

      I added a new test covering this case, so I think that running unit tests (course/tests/externallib_tests.php should be enough)
      You can also try to apply only the changes of the unit test and check that then it fails when they are executed, and with the whole patch it works.

      Show
      I added a new test covering this case, so I think that running unit tests (course/tests/externallib_tests.php should be enough) You can also try to apply only the changes of the unit test and check that then it fails when they are executed, and with the whole patch it works.

      It really uses clean_param for checking each parameter but at the end it assigns the uncleaned parameter again to a fresh conditions array.

      After talking with Eloy he decided that inside each case verifications for each type of param must be done, that means that the if (isset($value) should be removed

            jleyva Juan Leyva
            jleyva Juan Leyva
            Jun Pataleta Jun Pataleta
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.