Loading...

XML

Word

Printable

Affected Branches:
MOODLE_29_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
git://github.com/DanBennettUK/moodle.git
Pull Main Branch:
~~MDL-49115~~-master
Pull Main Diff URL:
https://github.com/DanBennettUK/moodle/compare/88cd577...MDL-49115-master
Testing Instructions:

Hide

1) Add an Amazon S3 Repository
2) Fill in Name, Access and Secure keys
3) Select an endpoint other than the default endpoint.
4) Save
5) Go back to the Amazon S3 settings and confirm Endpoint is still set to what you selected.

Show
1) Add an Amazon S3 Repository 2) Fill in Name, Access and Secure keys 3) Select an endpoint other than the default endpoint. 4) Save 5) Go back to the Amazon S3 settings and confirm Endpoint is still set to what you selected.

~~MDL-43752~~ had a line missing which is preventing the endpoint config being saved to the database.
This fixes it.

Fix is just for master as this is where it was integrated to. 27 and 28 are fixed in backport ~~MDL-49104~~

has a non-specific relationship to

MDL-49104 Amazon S3 Repository Endpoints (Backport of MDL-43752)

is a regression caused by

MDL-43752 S3 repository does not work for non-US repositories

Participants:: Andrew Lyons, CiBoT, Dan Bennett, David Monllaó, Eloy Lafuente (stronk7), Jetha Chan