Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48836

grouped_parser_processor::grouped_parent_exists is called too much (backport of MDL-41674)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7.8, 2.8.6
    • 2.7.4, 2.8.2
    • Backup
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • Hide

      1. Backup a course with users and questions
      2. Restore the course and confirm the users and question information is restored correctly.

      If you have XHProf installed and can restore the course prior to the patch, do that and save the result as a reference run.
      Then restore the course again and compare the results to ensure performance has not degraded.

      For further performance confirmation;
      1. Create a M or L course depending on your hardware.
      2. Backup that course
      3. Restore that course
      4. Apply the patch for MDL-48836
      5. Restore that course again.
      6. Compare performance of the two runs to ensure we have improved.

      Show
      1. Backup a course with users and questions 2. Restore the course and confirm the users and question information is restored correctly. If you have XHProf installed and can restore the course prior to the patch, do that and save the result as a reference run. Then restore the course again and compare the results to ensure performance has not degraded. For further performance confirmation; 1. Create a M or L course depending on your hardware. 2. Backup that course 3. Restore that course 4. Apply the patch for MDL-48836 5. Restore that course again. 6. Compare performance of the two runs to ensure we have improved.

      This is about to backport to stable branches (27 & 28 right now) the nice improvement @ MDL-41674 that landed only to master (2.9).

      It does not change any API, but (xml parser) internal stuff. Such parser is already extensively covered by tests and should be trouble-free.

      So this is the request to backport it. Original code should cherry-pick cleanly.

      Ciao

            markn Mark Nelson
            stronk7 Eloy Lafuente (stronk7)
            Andrew Lyons Andrew Lyons
            John Okely John Okely
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.