Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48070

login/index.php has no navigation block, so avoid loading course essential

XMLWordPrintable

    • MOODLE_28_STABLE
    • MOODLE_29_STABLE
    • 48070-29
    • Easy
    • Hide
      1. Log out if you are logged in, we are testing the login page first.
      2. Browse to the login page.
      3. Check that the page looks visually OK (identical to the week before this got integrated)
      4. In your text editor edit theme/bootstrapbase/config.php and give the login layout a block region 'side-pre', set the default region property to the same, and change the layout file to columns2.php
      5. Refresh the page in your browser and check that the navigation block is shown correctly as is the rest of the page.
      6. Log in as a user with the manager role in the system context
      7. Browse to the course category management page
      8. Check the page displays correctly, that the navigation and navbar are accurate.
      9. Log in as an admin
      10. Browse to the Web service test client
      11. Check the navbar and the navigation+settings on this page, they should be identical to last week.

      Behat will cover the rest luckily.

      Show
      Log out if you are logged in, we are testing the login page first. Browse to the login page. Check that the page looks visually OK (identical to the week before this got integrated) In your text editor edit theme/bootstrapbase/config.php and give the login layout a block region 'side-pre', set the default region property to the same, and change the layout file to columns2.php Refresh the page in your browser and check that the navigation block is shown correctly as is the rest of the page. Log in as a user with the manager role in the system context Browse to the course category management page Check the page displays correctly, that the navigation and navbar are accurate. Log in as an admin Browse to the Web service test client Check the navbar and the navigation+settings on this page, they should be identical to last week. Behat will cover the rest luckily.

      global_navigation::initalise() is called while checking navbar->has_items().

      On login/index.php we don't need to load whole navigation, we can optimise this api to improve performance.

      FYI:
      Not loading course_essentials reduce 2 dbread calls.

      $this->add_front_page_course_essentials($this->rootnodes['site'], $SITE);
      		 
      $this->load_course_sections($SITE, $this->rootnodes['site']);

            samhemelryk Sam Hemelryk
            rajeshtaneja Rajesh Taneja
            Rajesh Taneja Rajesh Taneja
            Dan Poltawski Dan Poltawski
            John Okely John Okely
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.