Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/zbdd/moodle.git
Pull Main Branch:
~~MDL-48031~~-master
Pull Main Diff URL:
https://github.com/zbdd/moodle/compare/e9b3e1e...MDL-48031-master
Testing Instructions:
Hide

Summary:

User bulk inserts were grabbing more than the grade items for that user to update. This should be fixed now.

Setup:

Atleast a M sized course.

Test One:

Bulk update using the Single view and using the User page. (select a User)

All the activities should update without having to click override on the grade items.

Test bulk updating empty grades and all grades.

Confirmation page should reflect the right amount of grades saved.
Show
Summary: User bulk inserts were grabbing more than the grade items for that user to update. This should be fixed now. Setup: Atleast a M sized course. Test One: Bulk update using the Single view and using the User page. (select a User) All the activities should update without having to click override on the grade items. Test bulk updating empty grades and all grades. Confirmation page should reflect the right amount of grades saved.

Steps to reproduce.

In Grades -> Singleview.
Select a User.
Select Bulk insert, add a grade > 0 and select for ALL GRADES.
Notice that grades saved is > than the amount of grade items for that user.
Notice (If using scales, or exceeding the limit of a range) you get multiple errors for other users.

Should only update for THAT users grades.

is blocked by

MDL-47893 Bulk updating grades for larger courses in single view causes database timeout

Participants:: Ankit Agarwal, CiBoT, Damyon Wiese, Dave Cooper, Eloy Lafuente (stronk7), Zachary Durber