Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47758

Revisiting a rule/sub delete URL should not throw an error

XMLWordPrintable

    • MOODLE_28_STABLE
    • MOODLE_28_STABLE
    • MDL-47758_master
    • Hide
      1. Visit a course.
      2. Visit Course administration -> Reports -> Event monitoring rules.
      3. Add a few rules.
      4. Click on the delete icon next to one of the rules.
      5. On the confirmation page click 'Cancel' and make sure you are taken back to the rule page.
      6. Click on the delete icon again and confirm the deletion.
      7. Revisit the delete URL and make sure you simply get redirected back to the rule page.
      8. Visit 'My profile settings' -> 'Event monitoring'.
      9. Subscribe to a few rules.
      10. Click on the delete icon next to a subscription.
      11. On the confirmation page click 'Cancel' and ensure you are taken back to the subscription page you were on before.
      12. Click on the delete icon again and confirm the deletion.
      13. Revisit the delete URL and make sure you simply get redirected back to the subscription page.
      Show
      Visit a course. Visit Course administration -> Reports -> Event monitoring rules. Add a few rules. Click on the delete icon next to one of the rules. On the confirmation page click 'Cancel' and make sure you are taken back to the rule page. Click on the delete icon again and confirm the deletion. Revisit the delete URL and make sure you simply get redirected back to the rule page. Visit 'My profile settings' -> 'Event monitoring'. Subscribe to a few rules. Click on the delete icon next to a subscription. On the confirmation page click 'Cancel' and ensure you are taken back to the subscription page you were on before. Click on the delete icon again and confirm the deletion. Revisit the delete URL and make sure you simply get redirected back to the subscription page.

      When deleting a rule we end up at actionable url, this bad practice (try refreshing the page). Should be a POST, but definitely shouldn't be able to refresh and end up with a database error. Haven't checked the extent of this problem, but also saw it on the subscription page.

            markn Mark Nelson
            markn Mark Nelson
            Adrian Greeve Adrian Greeve
            Dan Poltawski Dan Poltawski
            Frédéric Massart Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.