Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47648

Admin tree unit tests fail on cygwin (Windows)

XMLWordPrintable

    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Hide

      NOTE TO TESTER FROM DAN: It'd be great to have this fix independently verified on cygwin. If you have super important work to do instead of this, I am happy to call this passed by Tim's verification and the fact it doesn't break existing environments run by CI.

      Run the core_admintree_testcase unit tests on Windows with Cygwin (not using git-bash) and verify it now passes and previously failed.
      Run the core_admintree_testcase unit tests on Windows without Cygwin (not using git-bash) and verify it passes

      Show
      NOTE TO TESTER FROM DAN: It'd be great to have this fix independently verified on cygwin. If you have super important work to do instead of this, I am happy to call this passed by Tim's verification and the fact it doesn't break existing environments run by CI. Run the core_admintree_testcase unit tests on Windows with Cygwin (not using git-bash) and verify it now passes and previously failed. Run the core_admintree_testcase unit tests on Windows without Cygwin (not using git-bash) and verify it passes

      1) core_admintree_testcase::test_admin_setting_configexecutable
      Failed asserting that '
      <div class="form-item clearfix" id="admin-test1">
        <div class="form-label">
          <label for = "id_s__test1">Text 1</label>
          <span class="form-shortname">test1</span>
        </div>
        <div class="form-setting"><div class="form-file defaultsnext"><input type="text" size="50" id="id_s__test1" name="s__test1" value="C:\Users\tjh238\workspace\moodle_head/filter/tex/mimetex.exe" /><span class="patherror">&#x2718;</span></div><div class="form-defaultinfo">Default: Empty</div></div>
        <div class="form-description"><p>Help Path</p>
      </div>
      </div>' matches PCRE pattern "/class="pathok"/".
       
      C:\Users\tjh238\workspace\moodle_head\lib\tests\admintree_test.php:142
      C:\Users\tjh238\workspace\moodle_head\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       vendor/phpunit/phpunit/composer/bin/phpunit core_admintree_testcase lib\tests\admintree_test.php
      

        1. mimetex.exe.644.passing.png
          28 kB
          David Monllaó
        2. file perms.png
          40 kB
          Tim Hunt

            timhunt Tim Hunt
            timhunt Tim Hunt
            David Monllaó David Monllaó
            Dan Poltawski Dan Poltawski
            Rajesh Taneja Rajesh Taneja
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.