Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
git://github.com/kordan/moodle.git
Pull Main Branch:
~~MDL-47594~~_master
Pull Main Diff URL:
https://github.com/kordan/moodle/compare/master...MDL-47594_master
Difficulty:
Easy
Testing Instructions:

Hide

Buy an atomic clock and verify each call to lib/accesslib.php saves few nanoseconds
or
look at the code and verify the following code
if (empty($CFG->profileroles))
{ return array(); }
no longer exists from line 3113 of 7lib/accesslib.php.

More seriously: run unit tests lib/tests/accesslib_test.php

Show
Buy an atomic clock and verify each call to lib/accesslib.php saves few nanoseconds or look at the code and verify the following code if (empty($CFG->profileroles)) { return array(); } no longer exists from line 3113 of 7lib/accesslib.php. More seriously: run unit tests lib/tests/accesslib_test.php

As far as I can understand, the code in 3113 is a waste of time.

Participants:: CiBoT, Daniele Cordella, Dan Poltawski, Marina Glancy, Mark Nelson, Sam Hemelryk, Simey Lameze