Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Epic Link:
Grade history report
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-46678~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/da7c68e...MDL-46678-master
Testing Instructions:
Hide

Go to gradebook history report, after all the setup as requested in the parent issue.

Make sure the grader drop down looks ok and containts fullname of all the graders

Select a grader and submit, make sure the table is updated.

Run unit tests in grade/report/history/tests/report_test.php
Show
Go to gradebook history report, after all the setup as requested in the parent issue. Make sure the grader drop down looks ok and containts fullname of all the graders Select a grader and submit, make sure the table is updated. Run unit tests in grade/report/history/tests/report_test.php

Index.php has the following hardcoded sql

$sql = "SELECT u.id, ".$DB->sql_concat('u.lastname', "' '", 'u.firstname')."

        FROM {user} u

        JOIN {grade_grades_history} ggh ON ggh.usermodified = u.id

        JOIN {grade_items} gi ON gi.id = ggh.itemid

        WHERE gi.courseid = :courseid

        GROUP BY u.id

        ORDER BY u.lastname ASC, u.firstname ASC";

It needs to be moved to an api.

is blocked by

MDL-46573 Improve the SQL queries of the history report