Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46561

\core\session\manager::session_exists() does not check sessions table

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.8
    • 2.6.2, 2.7
    • General

      The \core\session\manager::session_exists() phpdocs says that it is not supposed to check the sessions table for existence of sid, but the WS code expects it anyway.

      I suppose it should be changed to first verify the db record for session exists and only if yes try to lookup the sid in session backend.

      This may be a security issue because the session gc may not always work properly - see MDL-46552

            skodak Petr Skoda
            skodak Petr Skoda
            Frédéric Massart Frédéric Massart
            Dan Poltawski Dan Poltawski
            Simey Lameze Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.