Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46513

mod/chat/report.php doesn't appear to be using fullname() correctly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.4.4, 3.5.1
    • 2.6.4, 3.4.3, 3.5
    • Chat
    • MOODLE_26_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-46513_master
    • Hide
      1. Create a course.
      2. Enrol two users as students.
      3. Create a chat activity.
      4. Log in as each user and enter the chat and type some messages (both users have to be in the chat at the same time in order for a chat session to be created, so use different browsers or private window).
      5. Log in as the admin.
      6. Search for the setting ‘fullnamedisplay’.
      7. Change it to 'firstname'.
      8. Visit the course.
      9. Click on the chat activity.
      10. Click on ‘View past chat sessions’.
      11. Confirm you can see the full names.
      12. Log in as one of the students.
      13. Visit the course.
      14. Click on the chat activity.
      15. Click on ‘View past chat sessions’.
      16. Confirm you can only see the first name.
      Show
      Create a course. Enrol two users as students. Create a chat activity. Log in as each user and enter the chat and type some messages (both users have to be in the chat at the same time in order for a chat session to be created, so use different browsers or private window). Log in as the admin. Search for the setting ‘fullnamedisplay’. Change it to 'firstname'. Visit the course. Click on the chat activity. Click on ‘View past chat sessions’. Confirm you can see the full names. Log in as one of the students. Visit the course. Click on the chat activity. Click on ‘View past chat sessions’. Confirm you can only see the first name. 

      echo ' '.fullname($user, true); // XXX TODO  use capability instead of true

      The comment seems nonsensical to me. Pretty sure that report.php shouldn't be supplying true. This is the function signature.

      fullname($user, $override=false)

        1. image-2018-06-06-17-06-08-755.png
          54 kB
          Janelle Barcega

            markn Mark Nelson
            andyjdavis Andrew Davis
            Carlos Escobedo Carlos Escobedo
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 13 minutes
                13m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.