Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46473

Improve usage of globals in mod/chat/chatd.php

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.7.1
    • Chat
    • MOODLE_27_STABLE

      The $GLOBALS array is directly manipulated and there is a variable $CHAT_HTMLHEAD_JS that is access via 'global' but which doesn't seem to be set anywhere.

      Some like

      "$GLOBALS['CFG']->wwwroot"

      look like they could be replaced by

      $CFG->wwwroot

      .

      Some like the following... I have no idea.

      if ($info['quirks'] & QUIRK_CHUNK_UPDATE) {
          $output->html .= $GLOBALS['CHAT_DUMMY_DATA'];
          $output->html .= $GLOBALS['CHAT_DUMMY_DATA'];
          $output->html .= $GLOBALS['CHAT_DUMMY_DATA'];
      }
      

            Unassigned Unassigned
            andyjdavis Andrew Davis
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.