Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46352

Deprecate print_group_picture

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 2.6.4, 2.7.1, 2.8
    • Libraries
    • MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-46352-master
    • Hide

      Initial setup

      1. Use the Make test course development functionality to create a test course (the S, 10mb size is fine).
      2. Navigate to the new course.
      3. Navigate to Course administration > Users > Groups.
      4. Click Auto-create groups and create four groups using the naming scheme Group @ for members with role Student.
      5. Navigate to Course administration > Users > Groups, and click the Groupings tab.
      6. Create a new grouping that contains your four new groups.
      7. Navigate to Course administration > Edit settings.
        • Set Group mode to Visible groups.
        • Set Default grouping to the grouping you just created.
      8. Navigate to the index of your new course, open the forum, and open a discussion.
        • Note that while all students in your course are in groups, no group_icons are displayed because no icons have been set for those groups.
      9. Navigate to Course administration > Users > Groups.
        • Add icons for each of your groups, but set the fourth group to have a hidden icon.
      10. Navigate to Course administration > Users > Groups, then click the Overview tab.
        • Observe that the group_pictures on group/overview.php are being rendered correctly.

      Visual tests (on both Base and Clean, on both LTR and RTL)

      1. Navigate back to the forum.
        • Observe that users now have group_pictures rendered under their avatars.
        • Observe that as an admin user, you have the course:managegroups permission and can thus see the fourth group's icon in spite of it being hidden.
      2. Make a note of the name of one of the users in the forum discussions, and add the user to an additional group (do not remove the user from their existing group).
        • Observe that the user in question now has icons for both groups.
      3. Subscribe to a discussion such that you get email notifications.
      4. Open a different browser and log in as a student enrolled in the course.
      5. Navigate to the forum.
        • Observe that as you do not have the course:managegroups permission, you do not see the fourth group's icon.
      6. Post in the discussion you subscribed to earlier.
      7. Wait for, or manually run cron.
        • Observe that group_pictures appear as they should in your email.
      8. As admin, click on one of the group_pictures attached to a forum post.
        • Observe that user/index.php renders a list of the users enrolled in the group, and more importantly the group_picture is rendered properly.
      9. Click the cog next to the group name.
        • Observe that the group_picture on group/group.php renders correctly.
      Show
      Initial setup Use the Make test course development functionality to create a test course (the S, 10mb size is fine). Navigate to the new course. Navigate to Course administration > Users > Groups . Click Auto-create groups and create four groups using the naming scheme Group @ for members with role Student. Navigate to Course administration > Users > Groups , and click the Groupings tab. Create a new grouping that contains your four new groups. Navigate to Course administration > Edit settings . Set Group mode to Visible groups . Set Default grouping to the grouping you just created. Navigate to the index of your new course, open the forum, and open a discussion. Note that while all students in your course are in groups, no group_icons are displayed because no icons have been set for those groups. Navigate to Course administration > Users > Groups . Add icons for each of your groups, but set the fourth group to have a hidden icon. Navigate to Course administration > Users > Groups , then click the Overview tab. Observe that the group_pictures on group/overview.php are being rendered correctly. Visual tests (on both Base and Clean, on both LTR and RTL) Navigate back to the forum. Observe that users now have group_pictures rendered under their avatars. Observe that as an admin user, you have the course:managegroups permission and can thus see the fourth group's icon in spite of it being hidden. Make a note of the name of one of the users in the forum discussions, and add the user to an additional group (do not remove the user from their existing group). Observe that the user in question now has icons for both groups. Subscribe to a discussion such that you get email notifications. Open a different browser and log in as a student enrolled in the course. Navigate to the forum. Observe that as you do not have the course:managegroups permission, you do not see the fourth group's icon. Post in the discussion you subscribed to earlier. Wait for, or manually run cron. Observe that group_pictures appear as they should in your email. As admin, click on one of the group_pictures attached to a forum post. Observe that user/index.php renders a list of the users enrolled in the group, and more importantly the group_picture is rendered properly. Click the cog next to the group name. Observe that the group_picture on group/group.php renders correctly.
    • 5
    • FRONTEND Sprint 13

      To support ongoing forum work (MDL-45862), print_group_picture is being deprecated in favour of a helper + renderable + renderer solution in the output library.

            Unassigned Unassigned
            jethac Jetha Chan
            Sam Hemelryk Sam Hemelryk
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.