Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45910

Exif data orientation of uploaded images seem to be ignored

XMLWordPrintable

    • MOODLE_23_STABLE, MOODLE_28_STABLE, MOODLE_310_STABLE, MOODLE_31_STABLE, MOODLE_39_STABLE
    • MDL-45910-MOODLE_401_STABLE
    • MDL-45910-MOODLE_403_STABLE
    • MDL-45910-image_cropping_issue_patch
    • Hide
      1. Create two users - a student and teacher
      2. Create a course
      3. Enroll both users - one as a student and one as a teacher
      4. Add a simple file submission assignment to the course
      5. Log in as the student
      6. As the student, submit a few images with varying EXIF data in the created assignment (you may want to use the images that are part of this patch in lib/filestorage/tests/fixtures/*EXIF/)
      7. Log in as the teacher
      8. As the teacher, grade the student's submission
      9. Confirm that all the images are correctly oriented on the PDF pages
      10. Confirm that none of the images are cut off by the page borders
      Show
      Create two users - a student and teacher Create a course Enroll both users - one as a student and one as a teacher Add a simple file submission assignment to the course Log in as the student As the student, submit a few images with varying EXIF data in the created assignment (you may want to use the images that are part of this patch in lib/filestorage/tests/fixtures/*EXIF/) Log in as the teacher As the teacher, grade the student's submission Confirm that all the images are correctly oriented on the PDF pages Confirm that none of the images are cut off by the page borders
    • 3
    • Team Alpha - Sprint 1 I1-2023

      I have uploaded student photos individually and using the bulk upload method and they always come up with the head of the photo 90 degrees to the left. these are .jpgs in version 2.3

      [UPDATE] More test instructions:
      a) In Windows 10, double click on an image. It should open the preview software. Select rotate. Windows 10 will automatically modify and save the "Orientation" exif data (Orientation: rotate 90). The image will be displayed rotated in Windows 10 now.
      b) Try to upload the image in a Moodle file resource. Once uploaded from the file picker, the image is displayed with the original orientation in the file manager (incorrect behavior). If you uploaded the same image in Facebook or Google Photo it would be displayed with the modified orientation (the expected behavior).

        1. AfterFixes.png
          37 kB
          Nejc Ačkun
        2. AfterFixes2.png
          19 kB
          Nejc Ačkun
        3. BeforeFixes.png
          19 kB
          Nejc Ačkun
        4. BeforeFixes2.png
          14 kB
          Nejc Ačkun
        5. drag and drop image to course page.png
          315 kB
          Haley Koch
        6. Example Correct rotation.jpeg
          100 kB
          Rick Jerz
        7. Example incorrect rotation.jpeg
          100 kB
          Rick Jerz
        8. file picker.png
          22 kB
          Haley Koch
        9. F iphone image-not working.jpeg
          4.67 MB
          Haley Koch
        10. image-2024-02-27-14-22-40-573.png
          33 kB
          Nejc Ačkun
        11. image-2024-02-27-14-23-37-709.png
          91 kB
          Nejc Ačkun
        12. image-2024-02-27-14-24-09-691.png
          105 kB
          Nejc Ačkun
        13. image-2024-02-27-14-24-38-007.png
          104 kB
          Nejc Ačkun
        14. image-2024-02-27-14-25-08-694.png
          106 kB
          Nejc Ačkun
        15. poc_gd_keep_orientation.patch
          3 kB
          Meirza
        16. rotate_image.png
          156 kB
          Adrian Greeve
        17. screenshot-fixtures-1.png
          132 kB
          Nejc Ačkun
        18. Screenshot from 2023-12-04 14-11-36.png
          190 kB
          Ilya Tregubov
        19. Screenshot from 2023-12-04 14-11-36-1.png
          190 kB
          Ilya Tregubov
        20. Screenshot from 2023-12-04 14-13-04.png
          1.09 MB
          Ilya Tregubov
        21. Screenshot from 2023-12-04 14-13-04-1.png
          1.09 MB
          Ilya Tregubov
        22. sideways profile image.png
          81 kB
          Haley Koch
        23. unit-test.png
          161 kB
          Adrian Greeve

            Votes:
            37 Vote for this issue
            Watchers:
            44 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 32 minutes
                1d 2h 32m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.