Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45425

Atto button highlighting incorrect when changing selection

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • Text editor Atto
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-45425-master
    • Hide
      1. Copy a large amount of text into an editor containing:
        • some links
        • some lists
        • some images
        • other stuff
      2. Select all
        • Confirm that the appropriate buttons are highlighted
      3. Click once on some plain text (not in a list, nor bold, not a link, etc)
        • Confirm that no buttons are highlighted
      4. Reselect all
        • Confirm that the appropriate buttons are highlighted again
      5. Click once on to place the caret in the middle of a link
        • Confirm that the link button is highlighted
      6. Reselect all
        • Confirm that the appropriate buttons are highlighted again
      7. Click once on to place the caret in the middle of a list
        • Confirm that the list button is highlighted
      8. Reselect all
        • Confirm that the appropriate buttons are highlighted again
      9. Try a few more buttons types, and links in lists, or bold in lists, etc.
        Important: It should only be necessary to click once for the buttons to update.
      Show
      Copy a large amount of text into an editor containing: some links some lists some images other stuff Select all Confirm that the appropriate buttons are highlighted Click once on some plain text (not in a list, nor bold, not a link, etc) Confirm that no buttons are highlighted Reselect all Confirm that the appropriate buttons are highlighted again Click once on to place the caret in the middle of a link Confirm that the link button is highlighted Reselect all Confirm that the appropriate buttons are highlighted again Click once on to place the caret in the middle of a list Confirm that the list button is highlighted Reselect all Confirm that the appropriate buttons are highlighted again Try a few more buttons types, and links in lists, or bold in lists, etc. Important: It should only be necessary to click once for the buttons to update.

      We update the button highlighting following a selectionchanged event triggered by _hasSelectionChanged.
      However, we do this on mouseup.
      Since the mouseup event is fired before the selection has changed, this is wrong.
      We need tomake it async.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Frédéric Massart Frédéric Massart
            Dan Poltawski Dan Poltawski
            Dan Poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.