Loading...

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Main Branch:
w17_~~MDL-45214~~_m27_idsortlog
Pull Main Diff URL:
https://github.com/skodak/moodle/compare/ff35a01...w17_MDL-45214_m27_idsortlog
Testing Instructions:

Hide

1/ execute phpunit tests
2/ go to log and live log report and verify they do not throw any warnings and events from one page appear to be sorted properly (for example you may try to change password - the user updated should be before password updated)

Show
1/ execute phpunit tests 2/ go to log and live log report and verify they do not throw any warnings and events from one page appear to be sorted properly (for example you may try to change password - the user updated should be before password updated)

The problem is that sorting events by time is not enough because PostgreSQL may then return events from one page in random order.

solution is to do something like:

    public function get_events_select($selectwhere, array $params, $sort, $limitfrom, $limitnum) {

        global $DB;

        if (empty($sort)) {

            $sort = "id ASC";

        } else if (stripos($sort, 'DESC') !== false) {

            $sort .= ", id DESC";

        } else {

            $sort .= ", id ASC";

Example: when using PG events from one page are printed out in random order in the livelog report.

Testing discovered

MDL-45203 convert remaining add_to_log() from login/lib.php

Participants:: Ankit Agarwal, CiBoT, Dan Poltawski, David Monllaó, Petr Skoda, Sam Hemelryk, Simey Lameze