Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44674

Atto wrapCallback setting should not exist

XMLWordPrintable

    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-44674-master
    • Hide

      Nothing was using the wrapCallback functionality - it was something I introduced to give us greater flexibility during design. As such, these testing instructions are to verify that we haven't introduced any new breakages.

      1. Check that all buttons work as anticipated.
      Show
      Nothing was using the wrapCallback functionality - it was something I introduced to give us greater flexibility during design. As such, these testing instructions are to verify that we haven't introduced any new breakages. Check that all buttons work as anticipated.

      If any atto plugin sets wrapCallback to false, it's not obvious that they then become responsible for all the aria toolbar keyboard handling/tabindex etc. This should be mandatory for all atto plugins, and they should only be able to opt out of the other parts of the wrapper function like setting focus on the content.

      This is a followup issue of MDL-44164.

            dobedobedoh Andrew Lyons
            damyon Damyon Wiese
            Frédéric Massart Frédéric Massart
            Dan Poltawski Dan Poltawski
            Adrian Greeve Adrian Greeve
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.