-
Bug
-
Resolution: Fixed
-
Minor
-
2.5.4, 2.6.1
-
MOODLE_25_STABLE, MOODLE_26_STABLE
-
MOODLE_25_STABLE, MOODLE_26_STABLE
-
MDL-44480-master -
- Open various dialogues, and check that the moodle-dialogue ID includes a load of gobbledygook (e.g. id="moodle-dialogue-yui_3_15_0_2_1394097024692_472"
- Make sure they open
- Run behat
When one bit of code creates a dialogue, but doesn't show it, then another bit of code creates a dialogue and tries to show it - the M.core.dialogue can get them confused and the contents of one will overwrite the other.
This occurs with Atto on the Add a rubric page. The delete criterion confirm dialogue does not display because it's content gets inserted to the wrong dom node.
The problem is M.core.dialogue uses a COUNT variable to give each dialogue a unique id, but this fails sometimes, and gets reset to 0 - so there are 2 dialogues with COUNT == 0.
A quick hack is:
- COUNT++;
+ COUNT = Math.floor((Math.random()*10000)+1);
from js/dialgoue.js
- blocks
-
MDL-43883 Convert Behat to use Atto instead of TinyMCE
-
- Closed
-