Loading...

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-44101~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/e6775c2...MDL-44101-master
Testing Instructions:
Hide

In all supported browsers:

Open the login page

Click on the [?] button so the help opens

Click on the [X] button to close it

*Confirm that focus was put back on the [?] button

Open it with the keyboard

Press [Escape]

*Confirm that focus was put back on the [?] button

Log in

Open a course page and turn editing on

Open an Activity chooser

Click on the [X] button to close it

*Confirm that focus was put back on the 'Add new activity or resource' link

Open it with the keyboard

Press [Escape]

*Confirm that focus was put back on the link
Show
In all supported browsers: Open the login page Click on the [?] button so the help opens Click on the [X] button to close it *Confirm that focus was put back on the [?] button Open it with the keyboard Press [Escape] *Confirm that focus was put back on the [?] button Log in Open a course page and turn editing on Open an Activity chooser Click on the [X] button to close it *Confirm that focus was put back on the 'Add new activity or resource' link Open it with the keyboard Press [Escape] *Confirm that focus was put back on the link

Ideally, when a dialogue is closed, it should focus on the item which opened it, or another appropriate contextual item.

This is a fairly generic thing to do so we should try and make this easy for everyone by creating a module which any widget can plug into.

blocks

MDL-44038 Atto: Focus on the editor is lost after opening a dialogue/menu

is blocked by

MDL-44079 Pressing escape in nested modal dialogues should only close the top dialogue

Participants:: Andrew Lyons, CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Jason Fowler