Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43886

moodle-core-dialogue leaves itself in the DOM after destroying itself

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43886-master
    • Hide
      Repeating instructions:
      • Click to open the dialogue
        • Confirm the dialogue appeared
        • Find the new dialogue in the DOM
      • Click Cancel
        • Confirm the dialogue has gone from the DOM
      • Repeat for the 'Remove' and [X] buttons.
      • Navigate to a course
      • Open course admin -> users -> enrolled users
      • Click the [X] next to a user's role
        • Process the Repeating instructions
      • Add a glossary with autolinking
      • Enable the glossary filter
      • Add some text to autolink
        • Process the Repeating instructions

      Check for regressions - these should not be removed from the DOM:

      • The chooser dialogue should open and close without being removed from the DOM
      • The EditPDF window, it's comments window, and other assorted dialogues should not be removed from the DOM
      • The help tooltip should open and close without being removed from the DOM
      Show
      Repeating instructions: Click to open the dialogue Confirm the dialogue appeared Find the new dialogue in the DOM Click Cancel Confirm the dialogue has gone from the DOM Repeat for the 'Remove' and [X] buttons. Navigate to a course Open course admin -> users -> enrolled users Click the [X] next to a user's role Process the Repeating instructions Add a glossary with autolinking Enable the glossary filter Add some text to autolink Process the Repeating instructions Check for regressions - these should not be removed from the DOM: The chooser dialogue should open and close without being removed from the DOM The EditPDF window, it's comments window, and other assorted dialogues should not be removed from the DOM The help tooltip should open and close without being removed from the DOM
    • 3
    • FRONTEND Sprint 9

      Noticed when trying to debug issues with the confirmation dialogue.
      Although we call destroy on the code, this does not actually remove it from the DOM.

      This is a minor issue but I think we should remove things from the DOM too to prevent confusion, and issues where the wrong dialogue is targetted somehow.

      Suggesting this as a master-only fix.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Damyon Wiese Damyon Wiese
            Sam Hemelryk Sam Hemelryk
            Jérôme Mouneyrac Jérôme Mouneyrac
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.