-
Bug
-
Resolution: Fixed
-
Minor
-
2.5.4, 2.6.1, 2.7
-
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
-
MOODLE_25_STABLE, MOODLE_26_STABLE
-
wip-
MDL-43821-master -
On the main page of a course, activity completion progress is reported for each section as "Progress: x / y". This is incorrect where the section contains quizzes requiring a non-zero passing grade as a pass is not counted as a completion.
To reproduce error:
Create a course in topics format, display one section per page, with a section containing one quiz and one url link.
Give the quiz a non-zero passing grade (through the gradebook) and activity completion criteria set to "Student must receive a grade to complete this activity".
For the url set the activity completion criteria to "Student must view this activity to complete it".
Log in as a student.
View the course front page.
The progress indicators for that section shows "Progress 0 / 2"
Enter the section and visit the link and fail the quiz.
View the course front page.
The progress indicators for that section shows "Progress 1 / 2"
Enter the section and pass the quiz.
View the course front page.
WHAT I EXPECTED:
The progress indicator shows "Progress: 2 / 2"
WHAT ACTUALLY HAPPENS:
The progress indicator shows "Progress: 1 / 2"
I think the problem is in renderer.php under course/format.
The offending line appears to count the activities with completion state COMPLETION_COMPLETE but not COMPLETION_COMPLETE_PASS:
if ($completiondata->completionstate == COMPLETION_COMPLETE)
Changing the code as follows appears to fix the problem to:
if ($completiondata->completionstate == COMPLETION_COMPLETE || $completiondata->completionstate == COMPLETION_COMPLETE_PASS) { $complete++; }
- has a non-specific relationship to
-
MDL-66482 Course section progress indication incorrect
-
- Open
-
-
MDL-42870 Course completion report not showing manually added grade after update to 2.5.2+
-
- Closed
-
- has been marked as being related by
-
MDL-47232 Course completion: "activities to be completed" improperly requires passing grade
-
- Closed
-