Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43798

Some get_records calls which could more explicitly be get_record

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Not a bug
    • Icon: Trivial Trivial
    • None
    • 2.7
    • Libraries, Questions

      Most trivial issue ever. But since I saw a load in a grep:

      $ sgrep -e '$DB->get_records(A, B, C, D, 0, 1, ...)' . 2> /dev/null
       
      enrol/database/lib.php:654
                   $categories = $DB->get_records('course_categories', array(), 'sortorder', 'id', 0, 1);
      enrol/ldap/lib.php:973
                   $categories = $DB->get_records('course_categories', array(), 'sortorder', 'id', 0, 1);
      grade/grading/form/guide/lib.php:566
                   if ($rs = $DB->get_records('grading_instances', array('raterid' => $raterid, 'itemid' => $itemid),
                       'timemodified DESC', '*', 0, 1)) {
      grade/grading/form/rubric/lib.php:573
                   if ($rs = $DB->get_records('grading_instances', $params, 'timemodified DESC', '*', 0, 1)) {
      lib/deprecatedlib.php:2593
               if ($category = $DB->get_records('course_categories', null, 'sortorder', '*', 0, 1)) {
      lib/questionlib.php:1034
           $category = $DB->get_records('question_categories',
                   array('contextid' => $contextid), 'id', '*', 0, 1);
      mod/assign/locallib.php:1987
               $submissions = $DB->get_records('assign_submission', $params, 'attemptnumber DESC', '*', 0, 1);
      mod/assign/locallib.php:2589
               $submissions = $DB->get_records('assign_submission', $params, 'attemptnumber DESC', '*', 0, 1);
      mod/assign/locallib.php:2705
               $grades = $DB->get_records('assign_grades', $params, 'attemptnumber DESC', '*', 0, 1);
      mod/lesson/locallib.php:1237
               if (!$timer = $DB->get_records('lesson_timer', array ("lessonid" => $this->properties->id, "userid" => $USER->id), 'starttime DESC', '*', 0, 1)) {
      mod/lesson/view.php:469
                           if (!$grades = $DB->get_records("lesson_grades", array("lessonid" => $lesson->id, "userid" => $USER->id), "completed DESC", '*', 0, 1)) {
      

      course/lib.php:3579
           $swapcourse = $DB->get_records_select('course', $select, $params, $sort, '*', 0, 1);
      lib/coursecatlib.php:2562
               $swapcategory = $DB->get_records_select('course_categories', $select, $params, $sort, '*', 0, 1);
      

            poltawski Dan Poltawski
            poltawski Dan Poltawski
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.