Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43538

Deprecate callback argument to confirm_action

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43538-master
    • Hide
      • git grep for confirm_action and check that no cases provide a callback
      • git grep for M.util.show_confirm_dialog
        • confirm that none of the cases provide a non-function based callback
      • run behat tests
      Show
      git grep for confirm_action and check that no cases provide a callback git grep for M.util.show_confirm_dialog confirm that none of the cases provide a non-function based callback run behat tests

      This is a first step to fixing MDL-42428.

      The callback argument is dirty and wrong, and leads to a JavaScript eval() which we should banish.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Petr Skoda Petr Skoda
            Sam Hemelryk Sam Hemelryk
            Andrew Davis Andrew Davis
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.