Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43323

Lazily load moodle-core-tooltip dependencies

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7
    • 2.7
    • JavaScript
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43323-master
    • Hide

      With the JS console open:

      • Open the login page
        • Confirm that there was no warning that moodle-core-notification has been deprecated
      • Click on the help dialogue
        • Confirm it appears as expected
      • Edit help_ajax.php and throw a new moodle_exception somewhere before the json_encode is output
      • Refresh the page
      • Click the help icon again
        • Confirm that the exception dialogue is shown
        • Confirm non warning about moodle-core-notification being deprecated in the console
      • Edit help_ajax.php again and remove the exception. Add an echo with some random content instead.
      • Click the help icon again
        • Confirm that the exception dialogue is shown
        • Confirm non warning about moodle-core-notification being deprecated in the console
      Show
      With the JS console open: Open the login page Confirm that there was no warning that moodle-core-notification has been deprecated Click on the help dialogue Confirm it appears as expected Edit help_ajax.php and throw a new moodle_exception somewhere before the json_encode is output Refresh the page Click the help icon again Confirm that the exception dialogue is shown Confirm non warning about moodle-core-notification being deprecated in the console Edit help_ajax.php again and remove the exception. Add an echo with some random content instead. Click the help icon again Confirm that the exception dialogue is shown Confirm non warning about moodle-core-notification being deprecated in the console
    • 5
    • FRONTEND Sprint 7

      We don't need all of moodle-core-dialogue in all cases and should lazily load those dependencies until we do actually need them.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Sam Hemelryk Sam Hemelryk
            Dan Poltawski Dan Poltawski
            Frédéric Massart Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.